Skip to content

fix: TT-226 Show user an error message when they try to save a time e… #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eduardisrael merged 3 commits into from
May 3, 2021
Merged

fix: TT-226 Show user an error message when they try to save a time e… #674

eduardisrael merged 3 commits into from
May 3, 2021

Conversation

@eduardisrael
Copy link
Contributor

@eduardisrael eduardisrael commented Apr 30, 2021

TT-226

This PR implement 'When the user tries to save, an error message should be shown that the clock out time can’t be before the clock in time'.

@eduardisrael eduardisrael added the bug Something isn't working label Apr 30, 2021
@codecov
Copy link

codecov bot commented Apr 30, 2021 •
edited
Loading

Codecov Report

Merging #674 (114323c) into master (13de42e) will increase coverage by 1.07%.
The diff coverage is 94.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
+ Coverage   93.09%   94.16%   +1.07%     
==========================================
  Files          85      103      +18     
  Lines        1564     1988     +424     
  Branches      107      141      +34     
==========================================
+ Hits         1456     1872     +416     
- Misses         67       75       +8     
  Partials       41       41
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...er-management/store/customer-management.effects.ts 83.78% <14.28%> (-16.22%) ⬇️
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...-management/store/activity-management.selectors.ts 77.77% <66.66%> (-9.73%) ⬇️
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...es-management/store/activity-management.effects.ts 94.59% <83.33%> (-5.41%) ⬇️
...app/modules/login/services/azure.ad.b2c.service.ts 80.00% <85.71%> (-2.36%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2126f...114323c. Read the comment docs.

@eduardisrael eduardisrael requested a review from LEON12699 April 30, 2021 15:01
thegreatyamori
thegreatyamori reviewed May 3, 2021
View reviewed changes
Copy link
Collaborator

@thegreatyamori thegreatyamori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job !!

@LEON12699
Copy link
Member

LEON12699 commented May 3, 2021

LGTM 🚀 !

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@eduardisrael eduardisrael merged commit 8a713d4 into master May 3, 2021
@eduardisrael eduardisrael deleted the TT-226-show-user-an-error-message-when-the-start-time-is-after-the-end-time branch May 3, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thegreatyamori thegreatyamori thegreatyamori approved these changes

@LEON12699 LEON12699 LEON12699 approved these changes

@scastillo-jp scastillo-jp Awaiting requested review from scastillo-jp

@Angeluz-07 Angeluz-07 Awaiting requested review from Angeluz-07

@VanessaIniguez VanessaIniguez Awaiting requested review from VanessaIniguez

@kellycastrof kellycastrof Awaiting requested review from kellycastrof

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eduardisrael @LEON12699 @thegreatyamori